You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 14, 2022. It is now read-only.
I have done some code inspection and digging. Turns out that the tabs implementation is only UI level and does not actually generate a separate session for each tabs with the backend. This means that there is only one socket being created with the server even though there might be multiple tabs. Hence the question of closing the connection with each tab does not arise since THERE IS NO SEPARATE SESSION.
Screenshots
Notice that both the tabs have the same ID and session ID. Which means that the frontend is not creating session based variables which are being passed to the backend. There is only one connection generated
Files
app.py
app.js
To Reproduce
Create a new tab and check the console log with the update code from PR.
Tasks
I am proposing that this remain the same. No need to spawn new worker threads for each and every tab since that would anyways be counter productive based on the fact that they are accessing the same CLI workspace. If a separate thread is needed, this can be further discussed. As of now, only UI level implementation of logging and session management is being added.
Then I think it's easier to convey in that case that the tab has been closed for inputs and is not connected to the back-end anymore. And if we want separate sessions by spawning separate workers like tabs in CLI should do then this would be prepped for that implementation.
Description
I have done some code inspection and digging. Turns out that the tabs implementation is only UI level and does not actually generate a separate session for each tabs with the backend. This means that there is only one socket being created with the server even though there might be multiple tabs.
Hence the question of closing the connection with each tab does not arise since THERE IS NO SEPARATE SESSION.
Screenshots
Notice that both the tabs have the same ID and session ID. Which means that the frontend is not creating session based variables which are being passed to the backend. There is only one connection generated
Files
app.py
app.js
To Reproduce
Create a new tab and check the console log with the update code from PR.
Tasks
I am proposing that this remain the same. No need to spawn new worker threads for each and every tab since that would anyways be counter productive based on the fact that they are accessing the same CLI workspace. If a separate thread is needed, this can be further discussed. As of now, only UI level implementation of logging and session management is being added.
This will be linked to enhancements and bugfixes such as Trying to download log of empty tab resets whole app #51 Session sharing #14 and Most Importantly Clear closed tabs #42
The text was updated successfully, but these errors were encountered: