Skip to content
This repository has been archived by the owner on Nov 14, 2022. It is now read-only.

Session Closing and Log Generation #66

Closed
2 tasks done
satanb4 opened this issue Nov 4, 2019 · 3 comments
Closed
2 tasks done

Session Closing and Log Generation #66

satanb4 opened this issue Nov 4, 2019 · 3 comments

Comments

@satanb4
Copy link
Contributor

satanb4 commented Nov 4, 2019

Description

I have done some code inspection and digging. Turns out that the tabs implementation is only UI level and does not actually generate a separate session for each tabs with the backend. This means that there is only one socket being created with the server even though there might be multiple tabs.
Hence the question of closing the connection with each tab does not arise since THERE IS NO SEPARATE SESSION.

Screenshots

Tab 1
Tab 2

Notice that both the tabs have the same ID and session ID. Which means that the frontend is not creating session based variables which are being passed to the backend. There is only one connection generated

Files

app.py
app.js

To Reproduce

Create a new tab and check the console log with the update code from PR.

Tasks

I am proposing that this remain the same. No need to spawn new worker threads for each and every tab since that would anyways be counter productive based on the fact that they are accessing the same CLI workspace. If a separate thread is needed, this can be further discussed. As of now, only UI level implementation of logging and session management is being added.

@0xHericles
Copy link
Owner

@satanb4 Yes, we have just one socket connection, but as I said in #68, the status badge refers to the socket connection, not the tabs. :/

And about closing tabs, the tab closing "doesn't actually close the session on the back-end". ;D

@satanb4
Copy link
Contributor Author

satanb4 commented Nov 4, 2019

Then I think it's easier to convey in that case that the tab has been closed for inputs and is not connected to the back-end anymore. And if we want separate sessions by spawning separate workers like tabs in CLI should do then this would be prepped for that implementation.

@satanb4
Copy link
Contributor Author

satanb4 commented Nov 6, 2019

Moving this Issue to #76 for closer inspection and discussion. Will be addressed in PR #68 for now

@satanb4 satanb4 closed this as completed Nov 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants