Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pirate Ship #8303

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Add Pirate Ship #8303

merged 4 commits into from
Dec 4, 2024

Conversation

contextnerror
Copy link
Contributor

@contextnerror contextnerror commented Dec 4, 2024

Only email is offered at the moment, being made mandatory Dec 6th.

Image is taken from https://brand.pirateship.com/logo and run through svgomg's default settings

@contextnerror
Copy link
Contributor Author

Apparently it's called "postal" and not "post"; the category names in CONTRIBUTING.md should be updated

@fletcherdodd fletcherdodd added the add site Issue/PR adds a site to the repo. label Dec 4, 2024
Copy link
Member

@Carlgo11 Carlgo11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request @contextnerror!
Just a few things you need to change before we can merge.

entries/p/pirateship.com.json Show resolved Hide resolved
img/p/pirateship.com.svg Outdated Show resolved Hide resolved
contextnerror and others added 2 commits December 4, 2024 15:29
Co-authored-by: Carl <[email protected]>
Signed-off-by: contextnerror <[email protected]>
Co-authored-by: Carl <[email protected]>
Signed-off-by: contextnerror <[email protected]>
Copy link
Member

@Carlgo11 Carlgo11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙂
Your contribution will be visible in around 10 minutes. Sometimes, it takes longer to show up due to server and browser caching.

@Carlgo11 Carlgo11 merged commit 80c8d0d into 2factorauth:master Dec 4, 2024
2 checks passed
@contextnerror contextnerror deleted the pirateship branch December 4, 2024 23:33
fletcherdodd added a commit to fletcherdodd/twofactorauth that referenced this pull request Dec 5, 2024
Fixing spelling error as reported in 2factorauth#8303
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add site Issue/PR adds a site to the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants