Improvements

[71m024]

Inbox

• Create Link-Component?
  • See AccessoryFor Link in flexirent-admin
  • combine with Color-Improvement?
• Why do invalid fields not show an eslint-error on flexirent-admin/IndividualProductPage_individualProduct fragment?
  • can't eslint detect invalid graphql-fields?

Prio 1

• There is a TypeError because the EntityState is Partial and not DeepPartial
  • see ts-expect-error in flexirent-admin in IndividualProductPage.tsx (on feature/re-login-handling branch)
  • ID's of new SortedMediaObjects should be nullable
  • Make EntityState DeepPartial (see branch feature/deep-partial)
• When a token expires, the page often has to be reloaded 100 times until the LoginForm appears
  • see feature/re-login-handling branch in relay-bee and flexirent-admin repos
  • Todos
    • AutoLoadTable in List-View is broken
    • Sorting in List-View is broken
• When relay-bee is completely extracted, check whether the LoadingIndicator in the NavigationLayout Suspense works again?
  • Does not currently work on the ActList. There the table header is displayed when loading and nothing else
• Same Queries are needed in Multi- and SingleMediaSelection. Two solutions:
  • Instead of passsing the same queries to both MediaSelection-Components, the MediaInsertion Component could be used directly and passed to the MediaSelection-Components.
  • Is it possible to specify fragments in relay-bee that can be spread into queries, that are passed to it?
    • could be usefull for the media-selection (see flexirent-admin/components/media)
    • At the moment one has to create very simmilar queries for every use of a media-selection on a specific schema.

Prio 2

• Is there a trick to tell relay which fields are used by the inputProps Helper?
  • Then it would not bee necessary to disable relay/unused-fields on the DetailPages
  • Perhaps one would have to implement a eslint-plugin? Or perhaps there is an even simpler trick :)
• Extract the generic part of the input-components (title and input-part).
  • Does it make sense? Input-Components defer in span-size.
  • Maybe only an extraction of the label?
• Why does navigation change size when one navigates from list-view to detail-view in flexirent-admin?
• The typing of the useRefetchListContext hook could probably be implemented more cleanly
  • It looks to me as if any variables can be passed at the moment
  • The type of the refetch callback should somehow be coupled with the type of the Variables?
• Make buttons on ListPage right-aligned
• Make the logged in user visible
• If there is a 500-error from the backend when deleting a product, it first says “successfully deleted” and then the error appears. Only the error should appear.

Prio 3

• It would be cleaner if SortedMediaObjects would be updated when they are reordert instead of creating new ones everytime
  • The Sortable Objects could be structured like this: {mediaObject.id -> id, -> id -> sortedId} and could be mapped to this structure and back
• Make a maker bundle plugin or something that automatically generates new pages
• It would also be great if the fields in the validation messages from Zod had the German names.
• Difference between LoadingIndicator and Spinner?
• Make sure that a color palette can be defined on the SystemContext, which is used as the base color.
  • In the OAD backend this is 'indigo', in FlexiRent this should probably be 'teal'?
  • It's best to google how you could/should parameterize such a color palette?
• Fix case errors in the breadcrumbs of the new-page
  • E.g. “neuer Produkt”