Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate WebResponse from C# #21

Open
9p4 opened this issue Apr 24, 2022 · 1 comment
Open

Separate WebResponse from C# #21

9p4 opened this issue Apr 24, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@9p4
Copy link
Owner

9p4 commented Apr 24, 2022

Related to #20

To simplify the code, separate the HTML in the WebResponse and use a template instead.

@9p4 9p4 added enhancement New feature or request good first issue Good for newcomers labels Apr 24, 2022
@strazto
Copy link
Collaborator

strazto commented Jun 19, 2022

Btw, this is supported (in part) by #34 - in #34 I make a mechanism for serving views from file (It has a different API path, from SSOController, though - /SSOViews instead of /SSO )

This does have significant implications, and I'd rather not move the auth client pages to different endpoints, since that'd involve reconfiguring redirect urls etc.

We could just combine the SSOViews controller into the SSO controller, or otherwise embed it

I haven't directly implemented templating - there's mainly just a question of which templating engine to use.

There seems to be plenty of community support for plenty of things. I'd rather steer clear of Razr or whatever the dotnet integrated stuff is, it seems very opinionated and maybe a bit heavyweight.

Some mustache implementation should be fine, maybe Stubble?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants