Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding logos #102

Open
sanjitcodes opened this issue Apr 17, 2020 · 3 comments
Open

Adding logos #102

sanjitcodes opened this issue Apr 17, 2020 · 3 comments
Labels
For Task-5

Comments

@sanjitcodes
Copy link
Contributor

sanjitcodes commented Apr 17, 2020 •
edited
Loading

Adding of logos of ACM(marked with blue) and university(here IGDTUW)(marked with green)
For #93
Screenshot 2020-04-17 at 5 37 14 PM
@sanjitcodes sanjitcodes changed the title Adding logos Adding logos for TASK 5 Apr 17, 2020
@lisa761
Copy link
Member

lisa761 commented Apr 17, 2020

Great work! Its good that you have come up with mocks for the UI. I agree with the acm logo and its position but I think we should move the position for IGDTUW logo as it kinda seems abrupt? @soumyaa1804 What do you think?

@lisa761
Copy link
Member

lisa761 commented Apr 17, 2020

Also, please edit your description to add For #93 so that it can create a mention in the Task-5 issue.

@sanjitcodes sanjitcodes changed the title Adding logos for TASK 5 Adding logos For #93 Apr 17, 2020
@soumyaa1804 soumyaa1804 changed the title Adding logos For #93 Adding logos Apr 17, 2020
@soumyaa1804
Copy link
Member

soumyaa1804 commented Apr 17, 2020 •
edited
Loading

Yes, it's a good idea. We have a logo which includes both ACM as well as IGDTUW in it. We can use that so that we do not require to add two logos. Having two logos near each other would not look visually nice so I guess 1 logo would be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
For Task-5
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@soumyaa1804 @lisa761 @sanjitcodes