Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout and Styling Challenges -ForTask5-"for #93" #113

Open
Jhanvi12 opened this issue Apr 17, 2020 · 3 comments
Open

Layout and Styling Challenges -ForTask5-"for #93" #113

Jhanvi12 opened this issue Apr 17, 2020 · 3 comments

Comments

@Jhanvi12
Copy link
Contributor

Jhanvi12 commented Apr 17, 2020

"for #93"

  1. The Android app development session, the spelling of room no is incorrect. Its Romm number. We must correct it.
  2. The navigation menu events, gallery,contact should redirect to another page.
  3. Maintain the uniformity regarding Location field. In some tile, its there and in some, it is absent.
  4. For Time, it is given in some tile, whereas it is not in some tile. In that case, we can show
    Yet to decide
  5. The symbol before location which we have used (the pin-like structure ), its colour can be changed to red just to show better and it will be the replication of google maps
@lisa761
Copy link
Member

lisa761 commented Apr 18, 2020

Hey @Jhanvi12, the first, third, fourth and fifth points are great! Although, I am not sure about the red color but it can be changed to make it more noticeable.
As for the second point, the links to those pages have been intentionally disabled and are not a part of this repository. Those links are present on the actual site, just not being used here because we felt it would be easier to keep the codebase small.

@lisa761
Copy link
Member

lisa761 commented Apr 18, 2020

Also, please add a for #93 in your description to create a mention in that task and change your title to better summarize the ideas you have suggested.

@Jhanvi12 Jhanvi12 changed the title For Task 5 Layout and Styling Challenges -ForTask5-"for #93" Apr 18, 2020
@Jhanvi12
Copy link
Contributor Author

Done the task advised by you! @lisa761, Can you pls check and revert!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants