Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added GitHub link and removed a broken CSS link #122

Closed
Tarster opened this issue Apr 18, 2020 · 6 comments · Fixed by #128
Closed

Added GitHub link and removed a broken CSS link #122

Tarster opened this issue Apr 18, 2020 · 6 comments · Fixed by #128
Labels
For Task-5

Comments

@Tarster
Copy link
Contributor

Tarster commented Apr 18, 2020

For #93
So, My small contribution to this awesome initiative is that I can add a GitHub and Instagram link in the footer.
@lisa761
Copy link
Member

lisa761 commented Apr 18, 2020

Hey @Tarster, that's a great idea but someone has already come up with this :(

@Tarster
Copy link
Contributor Author

Tarster commented Apr 18, 2020

Ohh, I haven't noticed it all but I have already implemented it for Instagram and GitHub.The one who had originally created the issue can also put LinkedIn link as I don't use that platform

@soumyaa1804
Copy link
Member

I think it would be fair if you implement it for GitHub and let the other person implement it for Instagram and LinkedIn.

@Tarster Tarster mentioned this issue Apr 18, 2020
Closed
@Tarster
Copy link
Contributor Author

Tarster commented Apr 18, 2020

yeah,ok that's fine for me.I will generate a new PR.

@Tarster Tarster closed this as completed Apr 19, 2020
@Tarster Tarster reopened this Apr 19, 2020
@lisa761
Copy link
Member

lisa761 commented Apr 19, 2020 •
edited
Loading

You should also edit your issue here to say that now you will be working on adding only the github link and removing the broken css link.

@Tarster Tarster mentioned this issue Apr 20, 2020
Merged
@Tarster Tarster changed the title Adding the project link in the social links Added GitHub link and removed a broken CSS link Apr 20, 2020
@Tarster
Copy link
Contributor Author

Tarster commented Apr 20, 2020

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
For Task-5
Projects
None yet
Milestone
No milestone
3 participants
@Tarster @soumyaa1804 @lisa761