Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Betterment of Node Server. #125

Open
Omkaragrawal opened this issue Apr 18, 2020 · 3 comments
Open

Betterment of Node Server. #125

Omkaragrawal opened this issue Apr 18, 2020 · 3 comments

Comments

@Omkaragrawal
Copy link
Contributor

I would like to make a few changes to the app.js files, so that the requests made are proper to and fro the node app.

@lisa761
Copy link
Member

lisa761 commented Apr 18, 2020

Hi, @Omkaragrawal, it would be great if you could explain here the changes you would like to make. In general, wait for your created issues to get a response or some discussion before spending time on a PR in case it is decided to not follow through with it. It will save a lot of your time.

@Omkaragrawal
Copy link
Contributor Author

Hey @lisa761 , Yep I totally understand.

The changes I made were:

I added a compression module
also I added Helmet module to the application.

Since I saw that this project was not equipped with some of the most important requirements, I added them.

@soumyaa1804
Copy link
Member

soumyaa1804 commented May 3, 2020

@Omkaragrawal, it is great that you have the knowledge of these modules but as we do not need to scale this project, we kept it simple and only necessary library and modules are added just to make it work. I don't think adding those changes will have any effect on the project right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants