Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dispose scale (slider) selection listeners from Preference page on page dispose #129

Open
AObuchow opened this issue Aug 27, 2020 · 2 comments
Open

Dispose scale (slider) selection listeners from Preference page on page dispose #129

AObuchow opened this issue Aug 27, 2020 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
2.0

Comments

@AObuchow
Copy link
Owner

As mentioned here, we should be disposing the selection listeners from the preference page's scales when the preference page is disposed.
@AObuchow AObuchow added the bug Something isn't working label Aug 27, 2020
@ingomohr
Copy link
Contributor

I can provide you with a PR for this next week if you like. :)

@AObuchow
Copy link
Owner Author

@ingomohr that would be awesome :) Please do when you have a moment!

@AObuchow AObuchow added the good first issue Good for newcomers label Sep 7, 2020
@AObuchow AObuchow added this to the 2.0 milestone Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@ingomohr @AObuchow