Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

n_iterations #98

Open
tihom opened this issue Mar 13, 2023 · 1 comment
Open

n_iterations #98

tihom opened this issue Mar 13, 2023 · 1 comment
Assignees

Comments

@tihom
Copy link
Collaborator

tihom commented Mar 13, 2023

@sandeep-iitr there have been few issues about the meaning of n_iterations in parallel mode. Intuitively (since all other tuning libraries have this behavior) n_iterations should be same as number of objective function evaluation but Mango does n_iterations x batch_size.

I propose that we deprecate n_iterations and add a new parameter: n_samples Number of function evaluation would always be == n_samples in serial and parallel cases. In parallel case the number of batches is calculated as n_samples / batch_size.

We would add a deprecation warning to n_iterations parameter to warn users about the change and update all docs and examples to use n_samples. This way it won't break existing usage.

I can make all the changes needed.

@tihom tihom self-assigned this Mar 13, 2023
@sandeep-iitr
Copy link
Collaborator

Hi Mohit, Thanks for raising.
I agree with your observations. More recently, we have seen many users asking for clarifications on the total number of samples vs the number of iterations parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants