Skip to content

Latest commit

 

History

History
58 lines (48 loc) · 2.09 KB

feedback.md

File metadata and controls

58 lines (48 loc) · 2.09 KB

Hotel

What We're Looking For

Test Inspection

Workflow yes / yes but no test / no
Wave 1
List rooms
Reserve a room for a given date range
Reserve a room (edge case)
List reservations for a given date
Calculate reservation price
Invalid date range produces an error
Test coverage
Wave 2
View available rooms for a given date range
Reserving a room that is not available produces an error
Test coverage
Wave 3
Create a block of rooms
Check if a block has rooms
Reserve a room from a block
Test coverage

Code Review

Baseline Feedback
Used git regularly
Answer comprehension questions
Design
Each class is responsible for a single piece of the program
Classes are loosely coupled
Fundamentals
Names variables, classes and modules appropriately
Understanding of variable scope - local vs instance
Can create complex logical structures utilizing variables
Appropriately uses methods to break down tasks into smaller simpler tasks
Understands the differences between class and instance methods
Appropriately uses iterators and Enumerable methods
Appropriately writes and utilizes classes
Appropriately utilizes modules as a namespace
Wrap Up
There is a refactors.txt file
The file provides a roadmap to future changes

Overall Feedback

Great work overall! You've built your first project with minimal starting code. This represents an incredible milestone in your journey, and you should be proud of yourself!

I am particularly impressed by the way that you...

I do see some room for improvement around...