Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS 15.0 (24A335)] Improve handling of already started client #7

Open
3 tasks done
ghost opened this issue Oct 3, 2024 · 1 comment
Open
3 tasks done

Comments

@ghost
Copy link

ghost commented Oct 3, 2024

Prerequisites

  • I have checked the Knowledge Base and the Discussions and found no answer

  • I have searched other issues and found no duplicates

  • I want to request a feature or enhancement and not ask a question

The problem

When starting the AGDNSC for a second time, an error is presented in the console stating:

user@MacBookPro AdGuardDNSClient % ./AdGuardDNSClient -s start -v
performing action "start": retrieving status: "launchctl" failed with stderr: Warning: Expecting a LaunchAgents path since the command was ran as user. Got LaunchDaemons instead.
`launchctl bootstrap` is a recommended alternative.
Load failed: 5: Input/output error
Try running `launchctl bootstrap` as root for richer errors.

AdGuard Home also experiences this, but dnsproxy does not.

Proposed solution

Better handle an already running service by checking whether it is already started and aborting with a more user friendly message such as "AdGuard DNS Client is already running".

Alternatives considered and additional information

No response

@Chinaski1
Copy link
Member

Hello!

At first glance it looks like you forgot to grant root permissions using sudo.
Let me know if the error is repeated in this combination as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant