-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature ideas: add translated selections to anki/add word context #39
Comments
Oops, my fault for not reading well, I see #2 is already an option. |
Not sure I understand what you're envisioning for your first suggestion. You want the sentence you looked up to be translated on the fly and inserted on the note as well? KOreader doesn't provide anything like that, you'd need to query some third party service. |
Neat, I admit I did not check at all whether KOreader supported that already, this was pretty straightforward: cf58b42 Could you give it a try and see if anything is missing? It inherits language settings from the settings you define in KOReader itself so it should be pretty simple. |
I will try to test, but having problems getting it working now, see #40 |
Should I expect to see an |
No, what I did is update the normal flow, if you look up a word in a dictionary and choose to add it, it will also add a translation of the current sentence, provided you filled in a value for the accompanying |
I took a quick look and adding the 'add to anki' button on the translation window wouldn't work without modifying the KOreader code base itself so I'd rather not try to get that to work |
However, I'm not sure if these are stored somewhere already.
The text was updated successfully, but these errors were encountered: