Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Give option to change output format #10

Open
Daja177 opened this issue Sep 10, 2024 · 3 comments
Open

[Feature Request] Give option to change output format #10

Daja177 opened this issue Sep 10, 2024 · 3 comments

Comments

@Daja177
Copy link
Contributor

Daja177 commented Sep 10, 2024

Not all my devices support the Ogg format, so it'd be great to have the option to output to MP3.

@tatsumoto-ren
Copy link
Member

Try to install a player app that can play ogg files. It should be available on every platform.

@Daja177
Copy link
Contributor Author

Daja177 commented Sep 10, 2024

Thanks for your response. The device in question is neither a computer nor a phone, and it isn't possible to install an additional player or anything to enable Ogg support. It supports MP3, AAC, M4A and WAV but not Ogg, so to use audio created with impd I have to convert it into any of these formats manually since impd is currently hardcoded to output Ogg specifically. While I recognize it's a fairly niche issue, there are people who prefer listening to music and/or condensed audio on separate devices, so allowing users to select the output format would really benefit users who have devices that don't support Ogg.

@tatsumoto-ren
Copy link
Member

impd is currently hardcoded to output Ogg specifically.

Yes.

To output mp3 we need to introduce a new config parameter that controls the output format. If it is set to mp3, the file extension and the codec should be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants