Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear parts before assigning in case of injective cache #59

Merged
merged 1 commit into from
Sep 30, 2023

Conversation

kris-brown
Copy link
Collaborator

Addresses #13

@kris-brown kris-brown self-assigned this Sep 28, 2023
@kris-brown kris-brown requested a review from olynch September 28, 2023 22:08
@kris-brown kris-brown added the bug Something isn't working label Sep 28, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (1655674) 89.93% compared to head (f1c5dee) 89.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
- Coverage   89.93%   89.88%   -0.05%     
==========================================
  Files          12       12              
  Lines        1083     1088       +5     
==========================================
+ Hits          974      978       +4     
- Misses        109      110       +1     
Files Coverage Δ
src/ACSetInterface.jl 90.35% <100.00%> (+0.17%) ⬆️
src/Columns.jl 91.42% <100.00%> (+0.25%) ⬆️
src/PreimageCaches.jl 79.24% <100.00%> (+0.81%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@epatters epatters changed the title clear parts before assigning in case of injective cache Clear parts before assigning in case of injective cache Sep 28, 2023
@epatters epatters merged commit f1c5dee into main Sep 30, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants