Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing dependence on layout of dual simplices #96

Open
lukem12345 opened this issue Jun 4, 2024 · 1 comment
Open

Removing dependence on layout of dual simplices #96

lukem12345 opened this issue Jun 4, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@lukem12345
Copy link
Member

          Checking that this is the dual vertex that is at the center of a primal vertex may just "fall out" of using our accessors in a certain order. So the following reliance on checking if it is in 1:nv(sd) may be unnecessary.

Originally posted by @lukem12345 in #95 (comment)

@lukem12345 lukem12345 added the enhancement New feature or request label Jun 4, 2024
@lukem12345 lukem12345 self-assigned this Jun 4, 2024
@lukem12345
Copy link
Member Author

Currently, certain operators in the FastDEC module are made speedier by relying on dual simplices being added into the dual complex in a certain order at construction time. This can sometimes lead to big speedups.

However, relying on the construction order is inherently a more fragile approach than using our more generic accessors.

So, we should re-review the FastDEC module and see where this fragility can be eliminated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant