Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize reward delivery times #57

Open
alexpiet opened this issue Nov 9, 2024 · 2 comments
Open

Reorganize reward delivery times #57

alexpiet opened this issue Nov 9, 2024 · 2 comments

Comments

@alexpiet
Copy link
Collaborator

alexpiet commented Nov 9, 2024

Instead of having all rewards grouped together as "right_reward_delivery_time" and then using the "data" column for annotating earned, manual, and auto, we could break them out as separate events.

Note that we could also do this at the level of the NWB - have separate acquisition time series for manual and earned. What do you think @rachelstephlee @Ahad-Allen

@rachelstephlee
Copy link
Collaborator

IMO it might be too much for this to be done in the level of NWB-- if we have slightly different type of task or different type of rewards, we'll have to edit the NWB packaging all over again.

to be clear-- you mean that this is a problem for df_events, correct?

just want to make sure i can replicate this on my end before i give design decisions.

@Ahad-Allen
Copy link
Collaborator

If these will vary by project then I think it makes more sense to place them all in the reward_delivery_time as it makes scripts and tools able to be general purpose more easily. If there is unlikely to be much variance though, I think we can create a separate time series for each of these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants