Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass images instead of filenames to certain methods in decrosstalk #19

Open
arielleleon opened this issue Dec 18, 2023 · 0 comments
Open
Assignees

Comments

@arielleleon
Copy link
Collaborator

From this PR: #18

From @jkim0731
Instead of passing paths and frame index, can we re-factor def decrosstalk_roi_image_single_pair_from_episodic_mean_fov to take two images only? (on top of pixel_size, grid_interval, and max_grid_val). I think that was what BOQC had, I don't understand the need to passing fn and frame index instead.

From @jkim0731
If this refactoring possible, L202, p1y, p1x = get_motion_correction_crop_xy_range_from_both_planes(oeid, paired_id, input_dir) can be brought up one level to here and be calculated only once.

These are very valid comments but I will need to refactor a bit to pass in images to the functions. BOQC had the LIMS db to pull from and I will need to add better folder queries to get relevant filepaths.

@arielleleon arielleleon self-assigned this Dec 18, 2023
@arielleleon arielleleon mentioned this issue Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant