Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

9 apply mixing matrix to paired registered movie #10

Closed
wants to merge 24 commits into from
Closed

9 apply mixing matrix to paired registered movie #10

wants to merge 24 commits into from

Conversation

arielleleon
Copy link
Collaborator

@jkim0731

  • full paired registered movie is used to generate the decrosstalk movie
  • remove the decrosstalk temp file at the end of processing decrosstalk

@arielleleon arielleleon requested a review from jkim0731 November 19, 2023 19:43
@arielleleon arielleleon linked an issue Nov 19, 2023 that may be closed by this pull request
apply mixing matrix to paired registered movie #9
Open
jkim0731
jkim0731 reviewed Nov 19, 2023
View reviewed changes
Copy link
Collaborator

@jkim0731 jkim0731 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few comments about naming

code/run_capsule.py Outdated Show resolved Hide resolved
code/run_capsule.py Outdated Show resolved Hide resolved
code/run_capsule.py Show resolved Hide resolved
jkim0731
jkim0731 suggested changes Nov 20, 2023
View reviewed changes
code/run_capsule.py Outdated Show resolved Hide resolved
arielleleon and others added 7 commits November 20, 2023 16:25
@arielleleon
removing run_nonrigid
c289016
@arielleleon
asserting non rigid run on both planes
5a88dbe
@arielleleon
fixing naming
bab71c7
@arielleleon
Merge pull request #15 from AllenNeuralDynamics/5-merge-paired-plane-…
3693930 
…registration-into-this-capsule

5 merge paired plane registration into this capsule
@arielleleon
resolving MC
6d4a2a6
@arielleleon
Merge pull request #16 from AllenNeuralDynamics/7-save-off-emf-episod…
96654b7 
…ic-mean-fov-for-the-decrosstalk-movie

7 save off emf episodic mean fov for the decrosstalk movie
@arielleleon
reversing name change
beae72e
@arielleleon
Copy link
Collaborator Author

Closing to merge into development

@arielleleon arielleleon deleted the 9-apply-mixing-matrix-to-paired-registered-movie branch November 21, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkim0731 jkim0731 jkim0731 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

apply mixing matrix to paired registered movie
2 participants
@arielleleon @jkim0731