Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically clean FXGL infinite animations if entity is not active #1377

Open
AlmasB opened this issue Jul 16, 2024 · 2 comments
Open

Automatically clean FXGL infinite animations if entity is not active #1377

AlmasB opened this issue Jul 16, 2024 · 2 comments

Comments

@AlmasB
Copy link
Owner

AlmasB commented Jul 16, 2024

Otherwise we end up with dead animations that still use resources

@DeathPhoenix22
Copy link
Contributor

DeathPhoenix22 commented Dec 10, 2024

Hi Almas,

In my case, what I did was tricky, but extensively powerful. One of the first change I did was using a set of Visibility conditions and mark entites not visible to setVisible(false). But in the end, it wasn't enough, far from it. The problem is that JavaFX continued to check if there was anything dirty in that not visible tree and continued to recheck bounds etc etc.
So what truly helped was to remove the Nodes from the parent Node of the Entity. It basically changed everything. I hesitated months (no joke) to do it or not. It was tricky, but paid extensively!

@AlmasB
Copy link
Owner Author

AlmasB commented Dec 10, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants