Max Payne 2

[AlpyneDreams]

• May or may not work with unmapping
• LockRect - Invalid Call - Rhedox
  • Locking a texture that's already locked. Perhaps we are returning the wrong tex/surf somewhere, or failing to unlock something.
• Likely not an issue: Render states 164 and 136 (see Unimplemented render states #46)

[AlpyneDreams]

An apitrace will make things a lot easier if possible! However I can look into trying the game myself at some point.

[Blisto91]

Will look into apitrace. Can't remember if I've tried or not.

The game indeed crashes for me unless i turn off unmapping.
There is also an issue where the text in the main menu is invisible. This is a regression as it didnt used to be the case. Haven't bisected yet or tried with the latest few commits

[Blisto91]

Now crashes during loading before main menu since 25b4860

[Blisto91]

Now able to get to main menu. Tho text is still invisible so i need to look into that.

[AlpyneDreams]

I have fixed a couple tangentially related things however it still crashes. It seems the problem is not that we fail to unlock a texture, but that the program has an access violation (0xc0000005) and never gets to call UnlockRect.

[AlpyneDreams]

So presumably a bad pitch is being output and the game is writing out of bounds?

[AlpyneDreams]

I have fixed a couple tangentially related things however it still crashes. It seems the problem is not that we fail to unlock a texture, but that the program has an access violation (0xc0000005) and never gets to call UnlockRect.

Can't reproduce this now. It's just locking a surface twice. Can't figure out why.

Tested on 7cccee1, with d3d9.textureMemory = 0, but no dice. This may be a vendor issue as I am on Intel.

[AlpyneDreams]

Tested on latest master (f8e1f46) on a different Intel GPU. No dice