Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move webStorage to shared #14329

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: move webStorage to shared #14329

wants to merge 1 commit into from

Conversation

standeren
Copy link
Contributor

@standeren standeren commented Dec 23, 2024 •
edited
Loading

Description

  • Move WebStorage to root in shared.
  • Move useLocalStorage from @studio/components to shared/hooks also since it is dependent of WebStorage which is now an app-specific package.

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

@standeren standeren linked an issue Dec 23, 2024 that may be closed by this pull request
Move WebStorage out of pure-functions #14230
Open
@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. area/dashboard Area: Related to the dashboard application area/app-preview Area: Related to test and preview of apps that are developed in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. area/studio-root Area: Issues related to studio-root application area/overview Area: Related to the overview page frontend labels Dec 23, 2024
@standeren standeren added quality/code Violations from current rules for code, best practices, etc. Or just bad code. skip-releasenotes Issues that do not make sense to list in our release notes team/studio-domain1 skip-manual-testing PRs that do not need to be tested manually skip-documentation Issues where updating documentation is not relevant labels Dec 23, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.56%. Comparing base (cc8754c) to head (92190fe).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #14329      +/-   ##
==========================================
- Coverage   95.56%   95.56%   -0.01%     
==========================================
  Files        1843     1843              
  Lines       23886    23885       -1     
  Branches     2752     2752              
==========================================
- Hits        22827    22826       -1     
  Misses        802      802              
  Partials      257      257

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@standeren standeren force-pushed the 14230-move-webstorage-out-of-pure-functions branch from 66ddb19 to 92190fe Compare December 23, 2024 08:37
@github-actions github-actions bot added area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). area/text-editor Area: Related to creating, translating and editing texts. labels Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
area/app-preview Area: Related to test and preview of apps that are developed in Altinn Studio. area/dashboard Area: Related to the dashboard application area/overview Area: Related to the overview page area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). area/studio-root Area: Issues related to studio-root application area/text-editor Area: Related to creating, translating and editing texts. area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend quality/code Violations from current rules for code, best practices, etc. Or just bad code. skip-documentation Issues where updating documentation is not relevant skip-manual-testing PRs that do not need to be tested manually skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain1
Projects
Team Studio
Status: ⚠️ Blocked
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move WebStorage out of pure-functions
1 participant
@standeren