Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maximum size on pull requests #14280

Open
framitdavid opened this issue Dec 13, 2024 · 0 comments
Open

Maximum size on pull requests #14280

framitdavid opened this issue Dec 13, 2024 · 0 comments
Labels
kind/analysis Used when an issue needs to be analysed before it becomes a user story. quality/code Violations from current rules for code, best practices, etc. Or just bad code. team/studio-core

Comments

@framitdavid
Copy link
Collaborator

framitdavid commented Dec 13, 2024 •
edited
Loading

What and why

We should establish a maximum size limit for pull requests (PRs) to improve code review quality and efficiency. This would help ensure that reviews are manageable, changes are well-scoped, and feedback can be provided more effectively. 😊

Override PR

To accommodate exceptional cases, there should be an override mechanism that allows larger pull requests to bypass the maximum size limit when necessary.

How

Using Github Actions and labels?
@framitdavid framitdavid added kind/analysis Used when an issue needs to be analysed before it becomes a user story. quality/code Violations from current rules for code, best practices, etc. Or just bad code. team/studio-core labels Dec 13, 2024
@TomasEng TomasEng mentioned this issue Dec 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/analysis Used when an issue needs to be analysed before it becomes a user story. quality/code Violations from current rules for code, best practices, etc. Or just bad code. team/studio-core
Projects
Team Studio
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@framitdavid