Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IF: P2P request of needed hs messages received too early or joining network #1597

Closed
Tracked by #1508
heifner opened this issue Sep 5, 2023 · 2 comments
Closed
Tracked by #1508

Comments

@heifner
Copy link
Member

heifner commented Sep 5, 2023

  • hs_vote_message may be received before the corresponding hs_proposal_message
    • If determined invalid, then need a way to re-receive the message to process after the hs_proposal_message is received.
  • When restarting a node, it will receive hs_vote_message that are not appropriate from its view.
    • Should node request recent/relevant hs messages on startup or on re-connect to a peer.
@bhazzard
Copy link

bhazzard commented Sep 7, 2023

Depends on decisions in #1548. Should discuss after those decisions are resolved.

@arhag arhag moved this from Todo to Blocked in Team Backlog Sep 19, 2023
@bhazzard bhazzard added this to the Leap v6.0.0-rc1 milestone Nov 1, 2023
@arhag
Copy link
Member

arhag commented Nov 8, 2023

Unification of proposals with blocks means that we can take advantage of the existing re-request protocol and no new messages are needed.

@arhag arhag closed this as not planned Won't fix, can't repro, duplicate, stale Nov 8, 2023
@github-project-automation github-project-automation bot moved this from Blocked to Done in Team Backlog Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants