Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] Fix chainbase issue when shrinking the database size. #1875

Closed
greg7mdp opened this issue Nov 7, 2023 · 0 comments · Fixed by #1885
Closed

[5.0] Fix chainbase issue when shrinking the database size. #1875

greg7mdp opened this issue Nov 7, 2023 · 0 comments · Fixed by #1885
Assignees
Labels
bug Something isn't working 👍 lgtm

Comments

@greg7mdp
Copy link
Contributor

greg7mdp commented Nov 7, 2023

Along with the changes for map_private mode, an issue sneaked in that Matt identified in his testing.

When the user tries to shrink the chainbase db (i.e. sets chain-state-db-size-mb to a lower number) and restarts nodeos, we internally keep track of a wrong database_size, which leads to possible crashes.

@greg7mdp greg7mdp self-assigned this Nov 7, 2023
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Nov 7, 2023
@greg7mdp greg7mdp changed the title [5.0] Fix chainbase issues (shrink db, mmap failing when ram insufficient) [5.0] Fix chainbase issue when shrinking the database size. Nov 7, 2023
@ericpassmore ericpassmore added this to the Leap v5.0.0-rc3 milestone Nov 8, 2023
@BenjaminGormanPMP BenjaminGormanPMP moved this from Todo to In Progress in Team Backlog Nov 8, 2023
@BenjaminGormanPMP BenjaminGormanPMP moved this from In Progress to Awaiting Review in Team Backlog Nov 8, 2023
@greg7mdp greg7mdp added the bug Something isn't working label Nov 8, 2023
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 👍 lgtm
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants