Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signal signed_block_ptr and block_id instead of block_state_ptr #1957

Closed
heifner opened this issue Dec 6, 2023 · 0 comments · Fixed by #1996
Closed

Signal signed_block_ptr and block_id instead of block_state_ptr #1957

heifner opened this issue Dec 6, 2023 · 0 comments · Fixed by #1996
Assignees
@linh2931
Labels
👍 lgtm

Comments

@heifner
Copy link
Member

heifner commented Dec 6, 2023

See #1951 (comment)

Currently the controller signals block_state_ptr via signals accepted_block_header, accepted_block, and irreversible_block. I think abstraction would be better served to signal signed_block_ptr, block_id for these instead.
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Dec 6, 2023
@arhag arhag added 👍 lgtm and removed triage labels Dec 6, 2023
@arhag arhag changed the title Signal signed_block_ptr and block_id instead of block_state_ptr IF: Signal signed_block_ptr and block_id instead of block_state_ptr Dec 6, 2023
@arhag arhag mentioned this issue Dec 6, 2023
Closed
@linh2931 linh2931 self-assigned this Dec 12, 2023
@linh2931 linh2931 moved this from Todo to In Progress in Team Backlog Dec 12, 2023
@arhag arhag changed the title IF: Signal signed_block_ptr and block_id instead of block_state_ptr Signal signed_block_ptr and block_id instead of block_state_ptr Dec 13, 2023
@linh2931 linh2931 mentioned this issue Dec 17, 2023
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Backlog Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@linh2931 linh2931

Labels
👍 lgtm
Projects
Team Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean up controller signals to improve abstraction AntelopeIO/leap
4 participants
@heifner @arhag @linh2931 @enf-ci-bot