Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: add unit tests for finality_core #2259

Closed
Tracked by #2110
linh2931 opened this issue Feb 22, 2024 · 0 comments · Fixed by #2264
Closed
Tracked by #2110

IF: add unit tests for finality_core #2259

linh2931 opened this issue Feb 22, 2024 · 0 comments · Fixed by #2264
Assignees
@linh2931
Labels
👍 lgtm
Milestone
Leap v6.0.0-rc1

Comments

@linh2931
Copy link
Member

Tests in existing block_header_state_tests.cpp only test next transition of previous block_header_state_core. The tests are no longer applicable and were removed by #2245.

New unit tests for finality_core should be created instead.
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Feb 22, 2024
@linh2931 linh2931 mentioned this issue Feb 22, 2024
Merged
@arhag arhag added 👍 lgtm and removed triage labels Feb 23, 2024
@arhag arhag mentioned this issue Feb 23, 2024
Closed
@linh2931 linh2931 self-assigned this Feb 24, 2024
@linh2931 linh2931 mentioned this issue Feb 26, 2024
Merged
@linh2931 linh2931 moved this from Todo to Awaiting Review in Team Backlog Feb 26, 2024
@linh2931 linh2931 linked a pull request Feb 26, 2024 that will close this issue
IF: add unit tests for finality_core #2264
Merged
@linh2931 linh2931 added this to the Leap v6.0.0-rc1 milestone Feb 26, 2024
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@linh2931 linh2931

Labels
👍 lgtm
Projects
Team Backlog
Archived in project
Milestone
Leap v6.0.0-rc1
Development

Successfully merging a pull request may close this issue.

IF: add unit tests for finality_core AntelopeIO/leap
3 participants
@arhag @linh2931 @enf-ci-bot