Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Change Fork_db root to store block state #2283

Closed
Tracked by #2110
linh2931 opened this issue Mar 6, 2024 · 0 comments · Fixed by #2284
Closed
Tracked by #2110

IF: Change Fork_db root to store block state #2283

linh2931 opened this issue Mar 6, 2024 · 0 comments · Fixed by #2284
Assignees
@greg7mdp
Labels
👍 lgtm
Milestone
Leap v6.0.0-rc1

Comments

@linh2931
Copy link
Member

linh2931 commented Mar 6, 2024

Currently fork_db's root only stores block_header_state. #2080 requires copying valid structure from previous block_state to current one. This causes problems when previous block is the root.

  • Change fork_db root to store block_state.
  • Provide a new API to return block_state including root while keeping existing APIs unchanged
  • Make sure old-version fork_db with the root storing block_header_state can be opened.
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Mar 6, 2024
@linh2931 linh2931 self-assigned this Mar 6, 2024
@linh2931 linh2931 moved this from Todo to In Progress in Team Backlog Mar 6, 2024
@linh2931 linh2931 removed the triage label Mar 6, 2024
@linh2931 linh2931 assigned greg7mdp and unassigned linh2931 Mar 6, 2024
This was referenced Mar 6, 2024
Closed
Merged
@greg7mdp greg7mdp linked a pull request Mar 6, 2024 that will close this issue
IF: Change Fork_db root to store block state #2284
Merged
@greg7mdp greg7mdp moved this from In Progress to Done in Team Backlog Mar 6, 2024
@arhag arhag added the 👍 lgtm label Mar 6, 2024
@arhag arhag mentioned this issue Mar 6, 2024
Closed
@arhag arhag closed this as completed Mar 6, 2024
@arhag arhag removed this from the Instant Finality: Production-Ready milestone Mar 12, 2024
@BenjaminGormanPMP BenjaminGormanPMP added this to the Leap v6.0.0-rc1 milestone Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greg7mdp greg7mdp

Labels
👍 lgtm
Projects
Team Backlog
Archived in project
Milestone
Leap v6.0.0-rc1
Development

Successfully merging a pull request may close this issue.

IF: Change Fork_db root to store block state AntelopeIO/leap
5 participants
@greg7mdp @arhag @linh2931 @enf-ci-bot @BenjaminGormanPMP