Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Support Leap 5 Fork Database disk format and new Savanna disk format. #2285

Closed
Tracked by #2110
greg7mdp opened this issue Mar 6, 2024 · 0 comments · Fixed by #2306
Closed
Tracked by #2110

IF: Support Leap 5 Fork Database disk format and new Savanna disk format. #2285

greg7mdp opened this issue Mar 6, 2024 · 0 comments · Fixed by #2306
Assignees
@greg7mdp
Labels
👍 lgtm
Milestone
Leap v6.0.0-rc1

Comments

@greg7mdp
Copy link
Contributor

greg7mdp commented Mar 6, 2024 •
edited
Loading

The fork database changed for Savanna.

It can now be either a block_state_legacy and/or a block_state container, and the root stores a block_state instead of a block_header_state.

We need to support a new file format which will store either one fork_db (either legacy or not) or two fork_ds (as will exist during the transition).

Leap 5 file format stored only the header part of the root block_state_legacy. This was changed in the hotstuff_integration branch (see #2284).

Test tests/ship_streamer_if_test should also be re-enabled (uncomment in CMakeLists.txt).
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Mar 6, 2024
@greg7mdp greg7mdp mentioned this issue Mar 6, 2024
Merged
@arhag arhag added 👍 lgtm and removed triage labels Mar 6, 2024
@arhag arhag mentioned this issue Mar 6, 2024
Closed
greg7mdp added a commit that referenced this issue Mar 10, 2024
@greg7mdp
Comment out ship_streamer_if_test again, as it requires issue #2285.
5fb0cd6
@greg7mdp greg7mdp moved this from Todo to In Progress in Team Backlog Mar 11, 2024
@BenjaminGormanPMP BenjaminGormanPMP added this to the Leap v6.0.0-rc1 milestone Mar 11, 2024
@greg7mdp greg7mdp mentioned this issue Mar 12, 2024
Merged
@greg7mdp greg7mdp linked a pull request Mar 12, 2024 that will close this issue
IF: Support Leap 5 Fork Database disk format and new Savanna disk format. #2306
Merged
@BenjaminGormanPMP BenjaminGormanPMP moved this from In Progress to Awaiting Review in Team Backlog Mar 14, 2024
@greg7mdp greg7mdp moved this from Awaiting Review to Done in Team Backlog Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greg7mdp greg7mdp

Labels
👍 lgtm
Projects
Team Backlog
Archived in project
Milestone
Leap v6.0.0-rc1
Development

Successfully merging a pull request may close this issue.

IF: Support Leap 5 Fork Database disk format and new Savanna disk format. AntelopeIO/leap
4 participants
@greg7mdp @arhag @enf-ci-bot @BenjaminGormanPMP