Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: set_finalizers should take finalizer policy without the generation number #2345

Closed
arhag opened this issue Mar 27, 2024 · 0 comments · Fixed by #2388
Closed

IF: set_finalizers should take finalizer policy without the generation number #2345

arhag opened this issue Mar 27, 2024 · 0 comments · Fixed by #2388
Assignees
@greg7mdp
Labels
👍 lgtm
Milestone
Instant Finality:...

Comments

@arhag
Copy link
Member

arhag commented Mar 27, 2024

Currently it ignores the generation number provided as input and substitutes with the next one that it tracks. We should update the data structure expect by the host function to not include the generation number.
@arhag arhag added 👍 lgtm and removed triage labels Mar 27, 2024
@greg7mdp greg7mdp self-assigned this Apr 8, 2024
@greg7mdp greg7mdp moved this from Todo to In Progress in Team Backlog Apr 8, 2024
@greg7mdp greg7mdp mentioned this issue Apr 8, 2024
Merged
@greg7mdp greg7mdp moved this from In Progress to Awaiting Review in Team Backlog Apr 8, 2024
@greg7mdp greg7mdp moved this from Awaiting Review to Done in Team Backlog Apr 9, 2024
@greg7mdp greg7mdp closed this as completed Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greg7mdp greg7mdp

Labels
👍 lgtm
Projects
Team Backlog
Archived in project
Milestone
Instant Finality: Production-Ready
Development

Successfully merging a pull request may close this issue.

Increment finalizer_policy's generation when set_finalizers is executed. AntelopeIO/leap
3 participants
@greg7mdp @arhag @enf-ci-bot