Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fork_database unittests to cover best fork choice rules #10

Closed
heifner opened this issue Feb 26, 2024 · 2 comments · Fixed by #366
Closed

Add fork_database unittests to cover best fork choice rules #10

heifner opened this issue Feb 26, 2024 · 2 comments · Fixed by #366
Assignees

Comments

@heifner
Copy link
Member

heifner commented Feb 26, 2024

Depends on AntelopeIO/leap#2125

AntelopeIO/leap#2125 Did not add test coverage for fork_database best fork choice rules.
Add unittest coverage of fork choices with multiple branches and scenarios.

@arhag
Copy link
Member

arhag commented Feb 28, 2024

We need to consider a worst-case scenario of finalizers split apart for different branches, then rejoin together, and need to reach consensus on one of the branches through their votes. It requires one of them to choose to vote weakly to join the other.

@arhag arhag transferred this issue from AntelopeIO/leap Apr 10, 2024
@arhag arhag added this to the Savanna: Production-Ready milestone Apr 10, 2024
@arhag arhag changed the title IF: Add fork_database unittests to cover best fork choice rules Add fork_database unittests to cover best fork choice rules Apr 10, 2024
@greg7mdp greg7mdp self-assigned this Jun 21, 2024
@greg7mdp greg7mdp moved this from Todo to In Progress in Team Backlog Jun 21, 2024
@arhag
Copy link
Member

arhag commented Jun 21, 2024

Create Savanna versions of the following tests from #196:

  • forking
  • prune_remove_branch
  • irreversible_mode
  • push_block_returns_forked_transactions

Also consider any tests needed to exercise any code paths that are not currently being exercised by the new fork choice rule implementation.

@BenjaminGormanPMP BenjaminGormanPMP moved this from In Progress to Awaiting Review in Team Backlog Jul 2, 2024
@BenjaminGormanPMP BenjaminGormanPMP moved this from Awaiting Review to Todo in Team Backlog Jul 11, 2024
@BenjaminGormanPMP BenjaminGormanPMP moved this from Todo to In Progress in Team Backlog Jul 11, 2024
@greg7mdp greg7mdp moved this from In Progress to Reviewer Approved in Team Backlog Jul 16, 2024
@github-project-automation github-project-automation bot moved this from Reviewer Approved to Done in Team Backlog Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants