Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we *only* vote on blocks which are in the best branch of fork_db? #779

Open
greg7mdp opened this issue Sep 13, 2024 · 0 comments
Open

Comments

@greg7mdp
Copy link
Contributor

greg7mdp commented Sep 13, 2024

Right now, we allow a vote only on blocks whose latest_qc_claim block or one of its descendants has been validated.

Since we can only be sure that the blocks in the best branch are validated, this implies that we also want to only vote on blocks that are in the best branch (otherwise the vote may fail unpredictably if we attempt to vote on a block not in the best branch, depending on whether or not that branch was ever the best branch and its blocks were validated).

Also, should we vote on a block whose core.latest_qc_claim() is for a block that is not in the best branch of fork_db? Right now we will vote iff that branch was the best branch at least once in the past (so the core.latest_qc_claim() block was validated).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

3 participants