Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update produced block and received block logs #787

Closed
heifner opened this issue Sep 16, 2024 · 0 comments · Fixed by #799 or #800
Closed

Update produced block and received block logs #787

heifner opened this issue Sep 16, 2024 · 0 comments · Fixed by #799 or #800
Assignees
@heifner
Labels
👍 lgtm OCI Work exclusive to OCI team
Milestone
Spring v1.0.2

Comments

@heifner
Copy link
Member

heifner commented Sep 16, 2024 •
edited by arhag
Loading

Remove confirmed from Produced block log message but only for Proper Savanna blocks.

info  2024-09-13T12:17:47.061 nodeos    controller.cpp:3637           log_applied          ] Received block 0079decc2f636cfd... #143 @ 2024-09-13T12:17:47.500 signed by eosio [trxs: 0, lib: 141, net: 0, cpu: 100, elapsed: 118, time: 724, latency: -438 ms]
info  2024-09-13T12:17:47.965 nodeos    controller.cpp:3473           commit_block         ] Produced block aa2c53635b62bb64... #144 @ 2024-09-13T12:17:48.000 signed by defproducera [trxs: 0, lib: 142, confirmed: 0, net: 0, cpu: 100, elapsed: 676, time: 3713]

Also lib should return the last_final_block_num of the block.
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Sep 16, 2024
@arhag arhag added 👍 lgtm and removed triage labels Sep 16, 2024
@arhag arhag added this to the Spring v1.0.2 milestone Sep 16, 2024
@heifner heifner self-assigned this Sep 18, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Sep 18, 2024
@heifner heifner moved this from Todo to In Progress in Team Backlog Sep 18, 2024
heifner added a commit that referenced this issue Sep 18, 2024
@heifner
GH-787 Update Produced block and Recieved block logs to report lib ac…
5a7d1ea 
…cording to block. Also do not report confirmed for savanna blocks.
@heifner heifner mentioned this issue Sep 18, 2024
Merged
heifner added a commit that referenced this issue Sep 18, 2024
@heifner
Merge pull request #799 from AntelopeIO/GH-787-logging
84f2e02 
[1.0.2] Update Produced block and Received block logs
heifner added a commit that referenced this issue Sep 18, 2024
@heifner
Merge remote-tracking branch 'spring/release/1.0' into GH-787-logging…
a907b06 
…-main
@heifner heifner mentioned this issue Sep 18, 2024
Merged
heifner added a commit that referenced this issue Sep 18, 2024
@heifner
Merge pull request #800 from AntelopeIO/GH-787-logging-main
2748d96 
[1.0.2 -> main] Update Produced block and Received block logs
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Backlog Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Archived in project
Milestone
Spring v1.0.2
3 participants
@heifner @arhag @enf-ci-bot