Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update raw.hpp so that we can serialize and deserialize const types #796

Closed
greg7mdp opened this issue Sep 18, 2024 · 0 comments · Fixed by #938
Closed

Update raw.hpp so that we can serialize and deserialize const types #796

greg7mdp opened this issue Sep 18, 2024 · 0 comments · Fixed by #938

Comments

@greg7mdp
Copy link
Contributor

greg7mdp commented Sep 18, 2024

Some types are only set in the constructor and never modified. So they are logically const and could be accessed from multiple threads safely.

Using this would allow us to remove some friend declarations (we use private as a way to prevent unchecked access to non thread-safe members).

Ideally we would make the member type const.
The serialization is what trips us up. I feel that the unpack functions in raw.hpp should accept to unpack into const members of structs (logically deserializing to recreate a value which is never modified after creation). Right now we cannot mark non-funadamental types that needs to be serialized const.

@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Sep 18, 2024
@greg7mdp greg7mdp self-assigned this Oct 15, 2024
@greg7mdp greg7mdp moved this from Todo to In Progress in Team Backlog Oct 15, 2024
@greg7mdp greg7mdp moved this from In Progress to Awaiting Review in Team Backlog Oct 15, 2024
@heifner heifner added this to the Spring v1.1.0-rc1 milestone Oct 15, 2024
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants