Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize LIB nomenclature #806

Closed
heifner opened this issue Sep 19, 2024 · 0 comments · Fixed by #918
Closed

Normalize LIB nomenclature #806

heifner opened this issue Sep 19, 2024 · 0 comments · Fixed by #918
Assignees
Labels
👍 lgtm OCI Work exclusive to OCI team tech-debt

Comments

@heifner
Copy link
Member

heifner commented Sep 19, 2024

There are a number of different things we call lib or last irreversible block.

  • Savanna block's core.last_final_block_num also known as irreversible_blocknum
  • Legacy block's dpos_irreversible_blocknum also known as irreversible_blocknum
  • fork database root
  • fork database pending_savanna_lib_id
  • block log head (might not exist if running with no block log)

Going forward we would like to use lib or last irreversible block in logs and documentation to refer to irreversible_blocknum which is the lib in respect to a given block. In locations where fork database root or fork database pending savanna lib is required they should be referred to fork_db_root/froot and fork_db_pending_lib. The block log head should be referred to simply as the block log head.

This issue is to examine and cleanup any log messages, method names, and comments in the code base to correspond to this new nomenclature.

@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Sep 19, 2024
@bhazzard bhazzard added this to the Spring v1.1.0-rc1 milestone Sep 20, 2024
@heifner heifner self-assigned this Oct 9, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Oct 9, 2024
@heifner heifner moved this from Todo to In Progress in Team Backlog Oct 9, 2024
heifner added a commit that referenced this issue Oct 9, 2024
…[num|id].

Use froot in logs that reference fork_db_root_block_num.
heifner added a commit that referenced this issue Oct 10, 2024
heifner added a commit that referenced this issue Oct 10, 2024
… fork_db_root_block_time() with fork_db_root()
heifner added a commit that referenced this issue Oct 10, 2024
heifner added a commit that referenced this issue Oct 10, 2024
heifner added a commit that referenced this issue Oct 11, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Backlog Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👍 lgtm OCI Work exclusive to OCI team tech-debt
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants