-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize LIB nomenclature #806
Comments
heifner
added a commit
that referenced
this issue
Oct 9, 2024
…[num|id]. Use froot in logs that reference fork_db_root_block_num.
Merged
heifner
added a commit
that referenced
this issue
Oct 10, 2024
… fork_db_root_block_time() with fork_db_root()
heifner
added a commit
that referenced
this issue
Oct 10, 2024
heifner
added a commit
that referenced
this issue
Oct 10, 2024
heifner
added a commit
that referenced
this issue
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are a number of different things we call
lib
orlast irreversible block
.core.last_final_block_num
also known asirreversible_blocknum
dpos_irreversible_blocknum
also known asirreversible_blocknum
root
pending_savanna_lib_id
head
(might not exist if running with no block log)Going forward we would like to use
lib
orlast irreversible block
in logs and documentation to refer toirreversible_blocknum
which is the lib in respect to a given block. In locations where fork database root or fork database pending savanna lib is required they should be referred tofork_db_root
/froot
andfork_db_pending_lib
. The block log head should be referred to simply as the block log head.This issue is to examine and cleanup any log messages, method names, and comments in the code base to correspond to this new nomenclature.
The text was updated successfully, but these errors were encountered: