-
-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better categorisation #1938
Comments
Given that you probably already considered the one obvious way that's already in use and me currently not being available, I'm not going to suggest it as the best way to go. While the additional step for every new contribution Inspiration could obviously be taken from the sorting Izzy or F-Droid are using, including a somewhat automatic renaming of some of the existing entries. I do like the idea though. ==== Anyone not aware of the current method
Would allow for
Kinda the way I have been labeling Icons for other Icon Packs with '_icon' or mostly korean based apps with '_kr'. (mostly to avoid future conflicts) Obviously leads to a bunch of potential issues and conflicts (depending on the categories chosen). |
I've added a Google and Microsoft line in the preparerelease script, so that should be covered now. I don't think it's a good idea to add a |
One actually "obvious" and probably quite useful would be an "Alt" category which lists every '_alt_x' currently in the pack. |
I just had a thought. It still requires many manual edits, but worth a shot, maybe. What if the preparereleasescript starts with all the normal stuff: new, calendar, emoji, brands etc. and after that searches through a different file, for example a game category. In the game category file is a list that can be edited, so everyone can add additions to it.
After the script has done that, it continues with the last part, ordering everything. |
That would be possible the good thing with this would be that the files don't need to be renamed |
Exactly, that was that I was thinking too :) |
I've added a simple XML file called games.xml to test with. However, I tried to understand how the preparereleasescript works, but just can't wrap my head around it. 🙃 https://github.com/Arcticons-Team/Arcticons/blob/main/scripts/games.xml |
I will write up something just need a bit of time. |
Hi, I'm not sure if I should add this here, but the folder tab contains icons for the apps called "folder in folder" and "folder widget" which probably shouldn't be there. Would renaming them so their names don't start with "folder_" work? |
Yes renaming them would work. |
I suggest using a different delimiter to separate categories from icon names. For example, the dot ( Icons can now be named like this google.google_docs.svg
microsoft.microsoft_word.svg
microsoft.wordament.svg ## Wordament is a Microsoft app, but without the "Microsoft" prefix
calendar.calendar_proton_12.svg
games.genshin_impact.svg The logic now is to check for the existence of the full stop in the filename. If there is one, anything before it will be a category. Downside: introducing this parsing logic means fixing the app code and website to display/search for icon names only, which is not trivial. Also this new syntax might confuse the contributors Edit: This might help with alternative icons too, for instance:
The generalized syntax will be of the following: <category>.<name>.alt-<alt-number>.svg ( |
. and - are not possible characters in Android |
Sorry, my answer was a bit brief. But we can create more and specific categories in the same way as the game category. |
I think we might want to add the "reserved prefix" like folder_ or microsoft_ somewhere in the contribution documentation too to prevent unrelated icons from appearing in those tabs because of the names. |
Maybe a separator of something like a prefix + 3 underscores would work?
This adds extra complexity to the codebase though, but if validated properly I think it's a neat(er) convention. Even more ideasI also suggest renaming icons when moving them into "official" directories, and only limit the use of this convention inside `/newicons`. That way the only metadata source needed would be the generated XMLs and not a prefix heuristic:
But this falls short of just manually editing the XML files lol |
But it's not needed. We have a seperate file for the game category: |
Does this mean doing away with prefix-based categories altogether (except for the obvious ones like letters and numbers), and maintaining them in XMLs? If so I'd be fine categorizing new icons manually, and maybe some old icons too. I'll await official contrib docs on this |
I don't see the benefit of handling the categories in a file. I think it is much easier to name the icons with a prefix instead of opening a file and at a line there. Also there is much more room for errors if you edit a file that should be machine readable. |
What if an app fits in two categories? Say you have a Microsoft game for example. |
that's a really good question with the prefix this isn't possible. But I also think it would introduce a strange behavior, because if an icon would be in two categories it would need to be twice inside the drawable.xml (don't know if this is possible to compile) also the icon count depends on the entries in the drawable.xml. |
That's not a problem.
There's a setting inside Candybar to show a custom number |
My main problem with prefixes is that they can be confusing when displayed ("Games Plants Vs Zombies" rather than "Plants Vs Zombies").
If so, then I think category files is good to go |
Candybar has also an option to rename apps. It could replace the prefix, but this costs performance.
With the games i the that it would be weird to have games before every entry. But the other Categories we have i think are good as they are.
For the games you are good to go. The file is located at |
Check this out: (System apps aren't implemented yet, but will be in the future. The file is present already, so apps can be categorized) |
Basically have some more categories so that the user can search the app more quickly, like:
The challenge would be how to do it with the automatic sorting.
The text was updated successfully, but these errors were encountered: