Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual regression on CI #5

Open
adekbadek opened this issue Mar 20, 2020 · 0 comments
Open

Visual regression on CI #5

adekbadek opened this issue Mar 20, 2020 · 0 comments

Comments

@adekbadek
Copy link
Member

Visual regression testing should be ran in CI.
Right now, this part is skipped, because of a font mismatch problem: CI run a Ubuntu system, which has a slightly different default sans-serif font than macOS. For this reason, all visual regression tests will fail because of that.

Possible solution: generate the base images on CI and commit from there (or download as artifacts and commit locally). This makes for a pretty cumbersome workflow, but maybe it's better in the long run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant