Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing translation texts for Sensei LMS Certificates (Block editor) #7693

Closed
amroland opened this issue Oct 26, 2024 · 3 comments
Closed

Missing translation texts for Sensei LMS Certificates (Block editor) #7693

amroland opened this issue Oct 26, 2024 · 3 comments
Labels
[Pri] Normal Can wait for the next release [Status] Triaged Issue has been triaged [Type] Bug
Milestone

Comments

@amroland
Copy link

Texts used in block editor are missing or not translated after translation CLI run.

Steps to Reproduce

  1. Install Sensei LMS Certificates.
  2. Switch to another language.
  3. Create a new course.
  4. Add "View Certificate" block.
  5. Check translation texts.

Missing from translation file (PO file):
"A Buttons block with a View Certificate button."
"Enable students to view their course certificate."

Not translated after CLI run:
"View Certificate"

PHP / WordPress / Sensei LMS version

PHP version 8.1.17
WordPress version 6.6.2
Sensei LMS Version: 4.24.3 | Sensei Pro Version: 1.24.1
Sensei LMS Certificate version 2.5.2

Screenshot / Video

Image
Image

@amroland amroland added [Status] Needs Triage Issue needs to be triaged [Type] Bug labels Oct 26, 2024
@donnapep donnapep added [Status] Triaged Issue has been triaged and removed [Status] Needs Triage Issue needs to be triaged labels Oct 28, 2024
@donnapep
Copy link
Collaborator

We likely need to add support for translating strings in JS files as we did for Sensei.

@donnapep
Copy link
Collaborator

Closing as I've moved this to the Certificates repo - woocommerce/sensei-certificates#359.

@donnapep
Copy link
Collaborator

Reopening so it can be added to our project board, but please use the Certificates issue for updates.

@donnapep donnapep reopened this Oct 28, 2024
@donnapep donnapep added this to the 4.24.4 milestone Oct 28, 2024
@donnapep donnapep modified the milestones: 4.24.4, 4.24.5 Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] Normal Can wait for the next release [Status] Triaged Issue has been triaged [Type] Bug
Projects
None yet
Development

No branches or pull requests

2 participants