Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Add end to end example starter module for AVM ALZ modules #29

Closed
jaredfholgate opened this issue Nov 2, 2023 · 2 comments
Closed

Feature Request: Add end to end example starter module for AVM ALZ modules #29

jaredfholgate opened this issue Nov 2, 2023 · 2 comments
Assignees
@jaredfholgate
Labels
enhancement New feature or request
Milestone
v1.0.0

Comments

@jaredfholgate
Copy link
Member

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Is your feature request related to a problem?

A stater module that leverages the new AVM ALZ modules and can be leverages by customers and VBD deliveries in the future. It should leverage the existing yaml based config pattern as used in the complete starter module.

Describe the solution you'd like

Additional context
@jaredfholgate jaredfholgate moved this from 🆕 New to 🏗 In progress in ALZ Terraform Accelerator Nov 2, 2023
@jaredfholgate jaredfholgate mentioned this issue Nov 2, 2023
Merged
5 tasks
@jaredfholgate jaredfholgate added the enhancement New feature or request label Nov 3, 2023
@jaredfholgate jaredfholgate self-assigned this Nov 3, 2023
@jaredfholgate
Copy link
Member Author

Started in #30

@jaredfholgate jaredfholgate added this to the v2.0.0 milestone Nov 14, 2023
jaredfholgate added a commit that referenced this issue Dec 11, 2023
@jaredfholgate
feature: complete modular starter module (#30)
ece7715 
<!-- Thank you for submitting a Pull Request. Please fill out the
template below.-->
## Overview/Summary

The PR adds an end to end example of using the new avm modules for ALZ.

## This PR fixes/adds/changes/removes

1. #29

### Breaking Changes

None

## Testing Evidence

The starter module has been run and generated a hierarchy with no
errors:

![image](https://github.com/Azure/alz-terraform-accelerator/assets/1612200/12dd11a6-cef6-4791-836a-2e6838571b40)

## As part of this Pull Request I have

- [x] Checked for duplicate [Pull
Requests](https://github.com/Azure/alz-terraform-accelerator/pulls)
- [x] Associated it with relevant
[issues](https://github.com/Azure/alz-terraform-accelerator/issues), for
tracking and closure.
- [x] Ensured my code/branch is up-to-date with the latest changes in
the `main`
[branch](https://github.com/Azure/alz-terraform-accelerator/tree/main)
- [x] Performed testing and provided evidence.
- [x] Updated relevant and associated documentation.
@jaredfholgate
Copy link
Member Author

Resolved issues and merged the PR.

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in ALZ Terraform Accelerator Dec 11, 2023
@jaredfholgate jaredfholgate modified the milestones: v2.0.0, v1.0.0 Jan 10, 2024
@jaredfholgate jaredfholgate moved this from ✅ Done to 📋 Backlog in ALZ Terraform Accelerator Jan 10, 2024
@jaredfholgate jaredfholgate modified the milestones: v1.0.0, v2.0.0 Jan 10, 2024
@jaredfholgate jaredfholgate moved this from 📋 Backlog to ✅ Done in ALZ Terraform Accelerator Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaredfholgate jaredfholgate

Labels
enhancement New feature or request
Projects
ALZ Terraform Accelerator
Status: ✅ Done
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@jaredfholgate