Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spike] Preflight Checks API integration #468

Open
savannahostrowski opened this issue Aug 12, 2022 · 10 comments · May be fixed by #4329
Open

[Spike] Preflight Checks API integration #468

savannahostrowski opened this issue Aug 12, 2022 · 10 comments · May be fixed by #4329

Comments

@savannahostrowski
Copy link

image

Steps to repro:

  1. Create a free account
  2. Pick a template (I believe Mandy used a node template)
  3. Choose East US 2 as region (apparently Central US region worked)
@Austinauth
Copy link

Austinauth commented Oct 11, 2022

@savannahostrowski a few clarifying questions:

  • Is the first step Create a free account something that the user has done prior to this error in the CLI?
  • Is a free account the same as a regular Azure account you can create using the Azure web UI or is it something more specific/nuanced?

@savannahostrowski
Copy link
Author

  1. Yes + you'll need to auth with the free account
  2. Free account with $200 credits link - https://azure.microsoft.com/en-us/free/

@savannahostrowski
Copy link
Author

Moved this to November!

@savannahostrowski savannahostrowski modified the milestones: Backlog, Gallium Apr 18, 2023
@savannahostrowski
Copy link
Author

This is part of planned work we have for Gallium to improve error messaging.

@savannahostrowski
Copy link
Author

Important for: Azure-Samples/azure-search-openai-demo#252

@rajeshkamal5050
Copy link
Contributor

rajeshkamal5050 commented Mar 22, 2024

There is a Preflight API which is implemented across services/RP's. which does the following types of checks.

  • Static validations
  • Resource name check
  • Quota check
  • Capacity check
  • SKUs
  • Region availability

@ChrisHMSFT do you know the status and coverage of the preflight API's on the RP's?

@rajeshkamal5050 rajeshkamal5050 changed the title [Issue] Help developers recover from capacity errors on free accounts Preflight Checks API integration Mar 22, 2024
@ChrisHMSFT
Copy link
Member

Yes, all except the capacity check is supported today. You can use: https://learn.microsoft.com/en-us/rest/api/resources/deployments/validate?view=rest-resources-2021-04-01

@rajeshkamal5050 rajeshkamal5050 modified the milestones: On Deck, Dilithium Mar 26, 2024
@rajeshkamal5050 rajeshkamal5050 changed the title Preflight Checks API integration [Spike] Preflight Checks API integration May 29, 2024
@hemarina
Copy link
Contributor

Preflight API has validation and deployment API. We already have deployment API. The enhancement is to add validation API to check failure before provision. The validation API is not working with all nested resources and our todo templates are using nested resources/module. However, adding validation API will help users validating their custom non-nested resources. There is a bug in azure-sdk-for-go preflight validate function: Azure/azure-sdk-for-go#23350 needs to resolve in order to add the enhancement to azd.

@rajeshkamal5050
Copy link
Contributor

Based on comment here #4329 (comment) moving to backlog. Depends on fix from bicep/preflight team fixing nested resources handling. @hemarina can you add the corresponding dependency issue here for tracking?

@hemarina
Copy link
Contributor

hemarina commented Dec 3, 2024

This issue will stay in backlog until preflight team release the fixes on nested resource: Azure/arm-template-whatif#157 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants