-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support skipping profile.ps1
loading in PowerShell Hooks by passing -NoProfile
#4595
Open
Yionse
wants to merge
7
commits into
Azure:main
Choose a base branch
from
Yionse:fix-issue#4592
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+21
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yionse
requested review from
ellismg,
wbreza,
vhvb1989,
hemarina,
weikanglim and
JeffreyCA
as code owners
December 3, 2024 09:36
Yionse
changed the title
Fix azd issue #4592
Support skipping Dec 3, 2024
profile.ps1
loading in PowerShell Hooks by passing -NoProfile
@rajeshkamal5050 Who should we reach out to for reviewing this PR? |
ellismg
reviewed
Dec 10, 2024
hemarina
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vhvb1989
reviewed
Dec 19, 2024
vhvb1989
approved these changes
Dec 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #4592. This pr determines whether to load
profile.ps1
by checking whether the first sentence of the PowerShell hook command ispwsh -NoProfile
.If the
profile.ps1
file exists in the current environment, but the user does not want to load the file when executing PowerShell hook scripts, the user can configurehooks
like this:If it is a script file, add
pwsh -NoProfile
before command.If it is a command, add
pwsh -NoProfile -Command
before command.@rajeshkamal5050 for notification.