Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container Registry: Allow specifying multiple scopes for a token in the AuthenticationClient #23810

Open
vlieven opened this issue Nov 29, 2024 · 1 comment
Labels
Client This issue points to a problem in the data-plane of the library. Container Registry customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@vlieven
Copy link

vlieven commented Nov 29, 2024

Feature Request

The azcontainerregistry.AuthenticationClient provides two methods for token exchange: ExchangeAADAccessTokenForACRRefreshToken and ExchangeACRRefreshTokenForACRAccessToken. The documentation for both these functions defines the scope parameter as follows:

scope - Which is expected to be a valid scope, and can be specified more than once for multiple scope requests.

The API indeed seems to support passing multiple values to represent multiple scope requests, but the SDK only allows passing a single string value, making it impossible to actually pass multiple scopes. Would it be possible to change the interface to allow multiple scopes to be provided? Or add new function calls that allows specifying multiple values?

@github-actions github-actions bot added Client This issue points to a problem in the data-plane of the library. Container Registry customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team. labels Nov 29, 2024
Copy link

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @northtyphoon @toddysm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Container Registry customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

1 participant