Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

automation support data plan #23879

Merged
merged 17 commits into from
Dec 27, 2024
Merged

automation support data plan #23879

merged 17 commits into from
Dec 27, 2024

Conversation

jliusan
Copy link
Member

@jliusan jliusan commented Dec 18, 2024

automation support data plan

tadelesh
tadelesh reviewed Dec 24, 2024
View reviewed changes
Copy link
Member

@tadelesh tadelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please merge the current main and remove the skip code for data plane sdk automation

eng/tools/generator/typespec/tspconfig.go Outdated Show resolved Hide resolved
eng/tools/generator/typespec/tspconfig.go Outdated Show resolved Hide resolved
eng/tools/generator/cmd/v2/automation/automationCmd.go Outdated Show resolved Hide resolved
eng/tools/generator/cmd/v2/common/generation.go Outdated Show resolved Hide resolved
eng/tools/generator/cmd/v2/common/constants.go Show resolved Hide resolved
eng/tools/generator/cmd/v2/common/generation.go Outdated Show resolved Hide resolved
@tadelesh
Copy link
Member

tadelesh commented Dec 24, 2024 •
edited
Loading

could you try with one mgmt. release from swagger, one mgmt. release from typespec, one mgmt. automation from swagger, one mgmt. automation from typespec and one data plane automation from typespec? please paste the result screenshot here. thanks.

@jliusan
Copy link
Member Author

jliusan commented Dec 26, 2024

automation from typespec
image
image
image

@jliusan
Copy link
Member Author

jliusan commented Dec 26, 2024

automation from a data plane of typespec
image
image
image

@jliusan
Copy link
Member Author

jliusan commented Dec 26, 2024

automation from swagger
image
image
image

@jliusan
Copy link
Member Author

jliusan commented Dec 26, 2024

release from typespec
image
image

@jliusan
Copy link
Member Author

jliusan commented Dec 26, 2024

release from swagger
image
image

tadelesh
tadelesh reviewed Dec 26, 2024
View reviewed changes
Copy link
Member

@tadelesh tadelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rename moduleRelativePath, relativePath all to packageModuleRelativePath

@tadelesh tadelesh merged commit bcb396b into Azure:main Dec 27, 2024
44 checks passed
@tadelesh tadelesh mentioned this pull request Dec 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadelesh tadelesh tadelesh approved these changes

@ArcturusZhang ArcturusZhang Awaiting requested review from ArcturusZhang ArcturusZhang is a code owner

@lirenhe lirenhe Awaiting requested review from lirenhe lirenhe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jliusan @tadelesh