Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVM Module Issue]: #61

Open
1 task done
vjmanda opened this issue May 23, 2024 · 10 comments
Open
1 task done

[AVM Module Issue]: #61

vjmanda opened this issue May 23, 2024 · 10 comments
Labels
Language: Terraform 🌐 This is related to the Terraform IaC language Status: Long Term ⏳ We will do it, but will take a longer amount of time due to complexity/priorities Type: Feature Request ➕ New feature or request

Comments

@vjmanda
Copy link

vjmanda commented May 23, 2024

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Feature Request

Feature request

Allow configuring private endpoints for the function app's backend storage account.

Description

The module currently only permits creating the function app's backend storage account publicly with no restrictions. This is the case even when the function app is configured with private endpoints.

Ideally the module should permit the function app to connect to the backend storage account privately using private endpoint connectivity.

@vjmanda vjmanda added Language: Terraform 🌐 This is related to the Terraform IaC language Needs: Triage 🔍 Maintainers need to triage still labels May 23, 2024
@donovm4
Copy link
Contributor

donovm4 commented May 28, 2024

Hi @vjmanda - I am currently working on a pattern module for function apps using secured storage. I believe the current workaround would be to leverage the function app resource module along with the storage account resource module.

@donovm4 donovm4 added the Status: Long Term ⏳ We will do it, but will take a longer amount of time due to complexity/priorities label May 28, 2024
@vjmanda
Copy link
Author

vjmanda commented May 28, 2024

Hi @vjmanda - I am currently working on a pattern module for function apps using secured storage. I believe the current workaround would be to leverage the function app resource module along with the storage account resource module.

@donovm4 - Should it be a pattern module though just to connect from the function app to backend storage securely?

@donovm4
Copy link
Contributor

donovm4 commented May 28, 2024

@vjmanda - one of the main factors for a pattern module being created is to aligned with this quickstart template for creating a Function App with private endpoint-secured Storage.

From my understanding, it would also be outside of the scope / spec to load up the resource module for function apps / web apps with all of the possible configurations / inputs for a storage account included, as it would overlap with a lot of the work already done for the separate existing resource module.

In this case, the separate resource modules for a storage account and function app have already been developed, so it would be easier to reference both modules individually to work together or use a pattern for a common task involving these resources, rather than duplicate the capabilities of the storage account module into the function app module.

Here is the original proposal

Feel free to open up an issue on AVM GitHub if you would like to provide feedback / insight on this particular issue.

@vjmanda
Copy link
Author

vjmanda commented May 28, 2024

Thanks @donovm4 - I will take a look at the pattern module proposal.

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-terraform) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

Note

This message was posted as per ITA01TF.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days label Jun 3, 2024

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-terraform) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

Note

This message was posted as per ITA01TF.

Caution

**This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-terraform) immediate attention as it hasn't been responded to within 6 business days. **

Tip

  • To avoid this rule being (re)triggered, the "Needs: Triage 🔍" and "Status: Response Overdue 🚩" labels must be removed when the issue is first responded to!
  • Remove the "Needs: Immediate Attention ‼️" label once the issue has been responded to.

Note

This message was posted as per ITA02TF.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Immediate Attention ‼️ Immediate attention of module owner / AVM team is needed label Jun 10, 2024

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-terraform) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

Note

This message was posted as per ITA01TF.

Caution

**This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-terraform) immediate attention as it hasn't been responded to within 6 business days. **

Tip

  • To avoid this rule being (re)triggered, the "Needs: Triage 🔍" and "Status: Response Overdue 🚩" labels must be removed when the issue is first responded to!
  • Remove the "Needs: Immediate Attention ‼️" label once the issue has been responded to.

Note

This message was posted as per ITA02TF.

@donovm4
Copy link
Contributor

donovm4 commented Jun 12, 2024

This module is still in development, and will be running through a code review in the near future

@donovm4 donovm4 removed Needs: Immediate Attention ‼️ Immediate attention of module owner / AVM team is needed Needs: Triage 🔍 Maintainers need to triage still Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days labels Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language: Terraform 🌐 This is related to the Terraform IaC language Status: Long Term ⏳ We will do it, but will take a longer amount of time due to complexity/priorities Type: Feature Request ➕ New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants