Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlocking countryballs after a trade on confirm stage times out #465

Open
domino6658 opened this issue Nov 19, 2024 · 2 comments
Open

Unlocking countryballs after a trade on confirm stage times out #465

domino6658 opened this issue Nov 19, 2024 · 2 comments

Comments

@domino6658
Copy link

Describe the feature you'd like
Countryballs would be unlocked immediately after ConfirmView times out. This would be done by adding a on_timeout callback which unlocks the balls in both player's proposals and then cancels the trade in a way similar to using the Cancel button.

Additional context
Currently, if the trade has not finished 90 seconds after both players have locked their proposals, the ConfirmView will time out and the balls will remain locked until 15 minutes have passed since the beggining of the trade.

@flaree
Copy link
Member

flaree commented Nov 19, 2024

It was intentionally left to wait the 15 minutes incase there's any issues and to avoid potential race conditions

@domino6658
Copy link
Author

domino6658 commented Nov 20, 2024

to avoid potential race conditions

@flaree what do you mean by this? would you please mind elaborating a bit on why it was intentionally left to wait 15 minutes and if or if not it can be changed?

@domino6658 domino6658 reopened this Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants