Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate GBIFResultsReader #55

Open
niconoe opened this issue Mar 18, 2016 · 4 comments
Open

Deprecate GBIFResultsReader #55

niconoe opened this issue Mar 18, 2016 · 4 comments
Assignees
Labels

Comments

@niconoe
Copy link
Member

niconoe commented Mar 18, 2016

Since it's a moving, unstandardized target.

We have to make it easy to use DwCAReader for features currently in GBIFResultsReader.

We have also to clearly document this deprecation/removal cycle.

@niconoe niconoe self-assigned this Mar 18, 2016
@niconoe
Copy link
Member Author

niconoe commented Mar 16, 2017

As of March 2017:

  • source_metadata features (the most important) have been moved to DwCAReader
  • rights/citations properties have not, but the doc is updated in order to show how to easily access them

@niconoe
Copy link
Member Author

niconoe commented Mar 16, 2017

  • The doc aslo states it's deprecated.

Next step: remove?

@tucotuco
Copy link

I think it would be clean to remove it and better for maintenance.

@niconoe
Copy link
Member Author

niconoe commented Mar 17, 2017

I think so!

So far, it's still working, but marked as "deprecated" in the doc, and the documentation in general has been updated to show the "new way". My idea is therefore to let it like this for a few months, then to simply remove it, for cleanliness and maintenance, as you suggested!

Does that sound like a good plan? Do you have any other suggestion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants