Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change gds naming conventions #61

Open
pvnbhargava opened this issue Sep 19, 2018 · 5 comments
Open

Change gds naming conventions #61

pvnbhargava opened this issue Sep 19, 2018 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@pvnbhargava
Copy link
Collaborator

Currently GDS's are named with the concatenation of the gds_filename and impl_lib parameters from the spec file. Change this to only use the gds_filename.

@pvnbhargava pvnbhargava added the bug Something isn't working label Sep 19, 2018
@pvnbhargava pvnbhargava self-assigned this Sep 19, 2018
@sbuchbinder sbuchbinder reopened this Dec 14, 2018
@sbuchbinder
Copy link
Collaborator

I am going to reopen this issue. I think we need to figure this out again in light of the refactor.
In db, there are lib_name and impl_cell uses that I am confused by.

@sbuchbinder sbuchbinder self-assigned this Dec 14, 2018
@pvnbhargava
Copy link
Collaborator Author

Yes, before now since gds generation was tied together with OA generation, TemplateDB utilized the impl_lib variable to name the gds. However, with the new separation of plugins, it's a good idea to change this up.

@sbuchbinder
Copy link
Collaborator

BigRefactor actually messes this up a bit because it uses the gds_plugin.export_content_list to export the design, which names the file based on the base gds_filepath and new property of gds_plugin called self.lib_name.
This means that the gds, flat gds, dataprep, and lsf gds-s are all named the same.

For now, I will hack together a solution where you pass an argument specifying how you want to append to the name...

@sbuchbinder
Copy link
Collaborator

We will also need to fix naming of the lsf exporter

@sbuchbinder
Copy link
Collaborator

in layout_manager, for impl_lib and impl_cell, to be compatible with bag:
check if they exist. if so use them, if not use project_name.
This allows us to remove impl_lib and impl_cell from the spec file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants