Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert all shapes to use unit_mode only #70

Open
pvnbhargava opened this issue Sep 29, 2018 · 0 comments
Open

Convert all shapes to use unit_mode only #70

pvnbhargava opened this issue Sep 29, 2018 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@pvnbhargava
Copy link
Collaborator

We would like to reduce the confusion and errors caused by accidentally using unit_mode and non-unit_mode values together. These can cause incompatibilities that are difficult to debug and resolve.

The tentative solution is to have all Photonic Objects assume that they are getting unit-mode values by default. It will be the job of PhotonicTemplateBase to convert non-unit mode values to unit-mode before creating objects. Note that Photonic Objects must still carry information about the resolution value and must be able to return non-unit mode values if prompted.

@pvnbhargava pvnbhargava added the enhancement New feature or request label Sep 29, 2018
@pvnbhargava pvnbhargava self-assigned this Sep 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant