Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from SHA1 to SHA256 #953

Open
1 of 3 tasks
kewde opened this issue Feb 24, 2017 · 9 comments
Open
1 of 3 tasks

Move from SHA1 to SHA256 #953

kewde opened this issue Feb 24, 2017 · 9 comments
Assignees
Labels
enhancement New feature
Milestone

Comments

@kewde
Copy link

kewde commented Feb 24, 2017

Recently the team at Google have found the first SHA1 collision,
the ECDSA signatures use SHA1 and most of the code for a switch to SHA256 is in the comments already.

https://security.googleblog.com/2017/02/announcing-first-sha1-collision.html

  • allow signing with SHA256 for people who want to experiment
  • make all signatures SHA256
  • disable support for SHA1 verification
@PeterSurda PeterSurda self-assigned this Feb 24, 2017
@PeterSurda PeterSurda added the enhancement New feature label Feb 24, 2017
@PeterSurda
Copy link
Member

PeterSurda commented Feb 24, 2017

@PeterSurda PeterSurda added this to the v0.6.5 milestone Feb 24, 2017
PeterSurda added a commit that referenced this issue Mar 2, 2017
- new variable "digestalg" which defaults to "sha1", but allows "sha256"
  for those who want to sign using this
- Addresses #953
@g1itch
Copy link
Collaborator

g1itch commented Mar 11, 2017

Wouldn't this potentially make it possible to use the bitcoin ASICs to spam bitmessage?

@kewde
Copy link
Author

kewde commented Mar 11, 2017

@g1itch I doubt it.
The ASICs operate under a very specific format that I doubt is applicable to BitMessage.

@PeterSurda
Copy link
Member

@g1itch Bitmessage uses double SHA512 for PoW, so no. The SHA1 -> SHA256 migration is only for sender authentication.

@kewde
Copy link
Author

kewde commented Sep 13, 2017

Has there been any progress on this issue?

@martinvahi
Copy link

Wouldn't this potentially make it possible to use the bitcoin ASICs to spam bitmessage?

The ASICs operate under a very specific format that I doubt is applicable to BitMessage.

If the ASIC's are implemented by using FPGAs, which might be the case to allow the same hardware, server park, to be reconfigured and reused for mining other cryptocoins after the Bitcoin "mine" has become "depleted enough", then the switch from one hash algorithm to another is not that big of an impediment for the server park owners.

@PeterSurda
Copy link
Member

@kewde You can specify that you want to send SHA256-hashed messages by specifying

digestalg = sha256

in the bitmessagemain section of keys.dat. The other steps outlined will progress as new releases are made.

@PeterSurda
Copy link
Member

This probably should be expedited, it's been waiting for too long. I've been running with digestalg = sha256 for a long time and haven't had issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature
Projects
None yet
Development

No branches or pull requests

4 participants