-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for bsl_backend using boost::multiprecision::complex in real to complex transforms. #19
Comments
I can add another example of real to complex using The current Jamfile under the test directory compiles the examples as if they were tests. To me this is not very elegant. Examples and tests are not the same thing, at least conceptually. On the other hand I remember Christopher (@ckormanyos) mentioning that we shouldn't add dependencies. To my understanding he meant no dependencies in the tests. But maybe we could have an |
Yes, it is not elegant, and I previously added some mess here. I'm sorry about that. Compiling examples is still necessary, because I remember at early stages, when PRs were going really fast I noticed that examples were being broken (some interface changes) and remained unfixed because they were not tested whether they still work. So yes, About what dependencies are allowed where I am not sure. Maybe @ckormanyos has some idea? :) |
I think Boost.Math's standalone attributes pertain only to Math's I also need to ask @mborland. Matt, when we develop for Math, and we want to retain the standalone attribute, can we add additional Boost-dependencies to examples and/or tests? |
Adding dependencies in examples and tests are fine, and generally needed to test all functionality. If any dependencies go into the include folder they need a guard for standalone. |
Issue #18 is dealing only with
boost::multiprecision::complex128
but we need to test the real to complex transforms also for typesmpfr
andcpp_bin_float
.The complex to complex transforms are tested in fft_ex05.cpp. Actually maybe this file should land in the test directory?
CC @Lagrang3 @ckormanyos
The text was updated successfully, but these errors were encountered: